Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Wasm support #111

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Added Wasm support #111

merged 1 commit into from
Feb 3, 2025

Conversation

KammererTob
Copy link
Contributor

This was mostly an oversight in the migration to package:web. In their migration (https://dart.dev/interop/js-interop/package-web#conditional-imports) they state that:

However, since dart:html is deprecated and not supported when compiling to Wasm, the correct alternative now is to use dart.library.js_interop to differentiate between native and web:

This was not done in our initial migration and thus Wasm didn't work properly although the code already can. This PR fixes that and also adjusts the test runner & tests themselves to support this.

One note on the test adjustment: The port returned from the hybrid code that simulates a server accepting Stomp connections comes back as a double in a Wasm environment and this is why we now check the type of the returned port and convert it accordingly.

@KammererTob KammererTob mentioned this pull request Feb 2, 2025
@KammererTob KammererTob merged commit 5240098 into master Feb 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant